*: optimize heartbeat process with concurrent runner - part 2 #8052
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
bot
added
the
release-note-none
ti-chi-bot
bot
added
the
size/XXL
nolouch
changed the title
ti-chi-bot
bot
added
the
needs-rebase
nolouch
force-pushed
the
optmize-heartbeat
branch
from
de81774
to
16e1028
Compare
ti-chi-bot
bot
added
size/L
nolouch
force-pushed
the
optmize-heartbeat
branch
from
16e1028
to
bb00939
Compare
nolouch
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8052 +/- ##
==========================================
+ Coverage 77.29% 77.34% +0.05%
==========================================
Files 470 470
Lines 61143 61225 +82
==========================================
+ Hits 47260 47355 +95
+ Misses 10320 10309 -11
+ Partials 3563 3561 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
nolouch
requested review from
JmPotato and
HuSharp
and removed request for
HunDunDM
Signed-off-by: nolouch <[email protected]>
nolouch
force-pushed
the
optmize-heartbeat
branch
from
bb00939
to
ef1bc25
Compare
ti-chi-bot
bot
added
size/XL
| collectFromItemSlice(r.leaders, storeID) | ||
| collectFromItemSlice(r.followers, storeID) | ||
| collectFromItemSlice(r.learners, storeID) | ||
| collectFromItemSlice(r.witnesses, storeID) |
There was a problem hiding this comment.
Is there a possibility that the following situation exists: I detected an overlap in the leaders tree and added item.RegionInfo, then, before I check other role trees, something like a leader transfer occurs. Will I not be able to get the latest item.RegionInfo because of this? Will there be any side effects?
There was a problem hiding this comment.
Here checks hold the lock, which means the new changes have not updated the subtree yet. So I think it's ok, then will handle the new updates.
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
ti-chi-bot
bot
added
status/LGT2
|
/merge |
|
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: f67c8a8
|
ti-chi-bot
bot
added
the
status/can-merge
|
@nolouch: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
) ref tikv#7897 Optimize heartbeat process - Split the statics updates on the subtree Signed-off-by: nolouch <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Ref #7897
What is changed and how does it work?
Check List
Tests
Before:
After:
The duration of the pending state on tikvs has been reduced from 10 minutes to 3 minutes
Release note